tblah added inline comments.
================
Comment at: flang/lib/Optimizer/Transforms/StackArrays.cpp:732
+ mlir::applyPartialConversion(func, target, std::move(patterns)))) {
+ mlir::emitError(func->getLoc(), "error in stack arrays optimization\n");
+ signalPassFailure();
----------------
tblah wrote:
> kiranchandramohan wrote:
> > Nit: Is this error usually given in passes?
> Sorry I don't understand. What change are you requesting here?
I've checked some other FIR passes and they all follow the same pattern.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140415/new/
https://reviews.llvm.org/D140415
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
