vbyakovl added inline comments.
================
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8681-8683
@@ -8680,5 +8676,3 @@
}
- return CheckVectorOperands(LHS, RHS, Loc, IsCompAssign,
- /*AllowBothBool*/true,
- /*AllowBoolConversions*/false);
}
----------------
aaron.ballman wrote:
> Are you saying that calling `CheckVectorOperands` was always incorrect? Or
> that it's no longer required because it should be fully covered by
> `checkVectorShift`? Because the two methods do considerably different
> checking, and I would have expected there to be more behavioral differences
> in the tests by removing the call to `CheckVectorOperands` that suggests
> there are tests missing.
Yes, calling CheckVectorOperands is not correct here because it compares
operand types to be the same. For shift it is not true.
Repository:
rL LLVM
https://reviews.llvm.org/D21678
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
