MaskRay added a comment.
LGTM
================
Comment at: clang/lib/Driver/ToolChains/LazyDetector.h:36
+ }
+ return &Detector.value();
+ }
----------------
tbaeder wrote:
> Is the `.value()` here permitted? AFAIK the convention is to always use
> `operator*`.
>
> And I think @aaron.ballman would tell you to drop the `{}` around that
> single-statement `if` :)
llvm style prefers `const T` to `T const`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142606/new/
https://reviews.llvm.org/D142606
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
