nickdesaulniers added a comment.
In D143300#4104469 <https://reviews.llvm.org/D143300#4104469>, @MaskRay wrote:
> `clang/test/CodeGen/init-randomized-struct-fwd-decl.c` passes without this
> patch. Is it correct?
Perhaps related to my comment about RecordDecl vs EnumDecl...
or the tests might require a specific randomization seed?
================
Comment at: clang/lib/Sema/SemaDecl.cpp:18891
+ // incomplete definition.
+ if (const auto *RD = dyn_cast<RecordDecl>(D))
+ return !RD->isCompleteDefinition();
----------------
what about `EnumDecl`s? I suspect the shared common base `TagDecl` might be
better to use?
If it is, can you add a test? I'm guessing
```
struct foo {
enum havent_seen_yet;
enum havent_seen_yet2;
}
```
would be the test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143300/new/
https://reviews.llvm.org/D143300
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
