vmiklos added inline comments.

================
Comment at: clang-rename/tool/ClangRename.cpp:65
@@ +64,3 @@
+
+  RenameAllInfo() : Offset(0) {}
+};
----------------
omtcyfz wrote:
> AFAIK there's no need to do that, integer types are by default initialized 
> with 0, aren't they?
Are you sure? Here is a minimal version that shows what goes wrong when that's 
not initialized explicitly: http://pastebin.com/raw/2ZsUgWf6 The "Use of 
uninitialised value of size 8" goes away with an explicit initialization.


https://reviews.llvm.org/D23198



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to