awarzynski added a comment.

In D143493#4110272 <https://reviews.llvm.org/D143493#4110272>, @skatrak wrote:

> It is introduced to the arguments list in `Clang::AddPreprocessingOptions` in 
> certain cases to add the OpenMP wrapper "__clang_openmp_device_functions.h" 
> to the list of includes for device offload.

This is a use case in Clang ;-)

> It seemed likely that we would need to add a similar mechanism eventually to 
> flang as well

Possibly, but it's not needed yet?

I would rather refrain from adding flags to Flang only because a similar flag 
exists in Clang. I suggest abandoning this until there's a clear need for this 
in Flang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143493/new/

https://reviews.llvm.org/D143493

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to