kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/Preamble.cpp:690
+ // it's coming from baseline preamble.
+ if (It->second) {
+ Inc.Resolved = It->second->Resolved;
----------------
sammccall wrote:
> why the null check?
as discussed offline, we might have includes coming from scanned contents whose
are not part of the preamble, e.g. because they're in a disabled PP region.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143197/new/
https://reviews.llvm.org/D143197
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
