kadircet added inline comments.
================ Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:218 + if (!D) // global scope. + return getMappingPerLang(L)->NamespaceSymbols->lookup(""); auto It = NamespaceCache.find(D); ---------------- oh i actually missed the behaviour change here in the previous version of the code and it seems very subtle. can we change this function to take in a `DeclContext*` instead and terminate traversal inside the callsite at `TUDecl` and only treat `TUDecl` as global scope here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits