kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/unittests/tweaks/DefineOutlineTests.cpp:89 + // Not available on methods of unnamed classes. + EXPECT_UNAVAILABLE(R"cpp( + struct Foo { ---------------- nit: i think you can group all these 3 tests. ``` // Not available if any of the parent context is unnamed, as we can't spell it. EXPECT_UNAVAILABLE(R"cpp( struct Foo { struct { void b^ar() {} struct Baz { void b^ar() {} }; } Bar; }; namespace { struct Foo { void f^oo() {} }; } )cpp"); ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143638/new/ https://reviews.llvm.org/D143638 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits