bjosv updated this revision to Diff 497344. bjosv added a comment. Updated to fill 80 char as proposed, and changed some wordings.
CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143996/new/ https://reviews.llvm.org/D143996 Files: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst Index: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst =================================================================== --- clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst +++ clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst @@ -32,7 +32,7 @@ char h = 0; }; -Variables: ``a``, ``c``, ``c_ptr1``, ``c_ptr2``, ``c_const_ptr`` and -``c_reference``, will all generate warnings since they are either: -a globally accessible variable and non-const, a pointer or reference providing -global access to non-const data or both. +The variables ``a``, ``c``, ``c_ptr1``, ``c_const_ptr`` and ``c_reference`` +will all generate warnings since they are either a non-const globally accessible +variable, a pointer or a reference providing global access to non-const data +or both.
Index: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst =================================================================== --- clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst +++ clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst @@ -32,7 +32,7 @@ char h = 0; }; -Variables: ``a``, ``c``, ``c_ptr1``, ``c_ptr2``, ``c_const_ptr`` and -``c_reference``, will all generate warnings since they are either: -a globally accessible variable and non-const, a pointer or reference providing -global access to non-const data or both. +The variables ``a``, ``c``, ``c_ptr1``, ``c_const_ptr`` and ``c_reference`` +will all generate warnings since they are either a non-const globally accessible +variable, a pointer or a reference providing global access to non-const data +or both.
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits