aeubanks accepted this revision.
aeubanks added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/unittests/IR/ModuleTest.cpp:49
EXPECT_FALSE(std::is_sorted(M.global_begin(), M.global_end(), compare));
- M.getGlobalList().sort(compare);
- EXPECT_TRUE(std::is_sorted(M.global_begin(), M.global_end(), compare));
+ // I removed this because it is testing whether ilist.sort() works, which
is
+ // not Module-specific. This requires access to the full GlobalList for no
----------------
can just delete the commented out lines and add the reasoning behind deleting
this either as a phabricator comment or in the commit description
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144027/new/
https://reviews.llvm.org/D144027
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
