jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: Prazek, cfe-commits.
getAsInteger returns true on error. Oops. No test because the behavior at the moment is identical with or without this change. https://reviews.llvm.org/D23340 Files: clang/lib/Driver/ToolChains.cpp Index: clang/lib/Driver/ToolChains.cpp =================================================================== --- clang/lib/Driver/ToolChains.cpp +++ clang/lib/Driver/ToolChains.cpp @@ -1730,8 +1730,8 @@ int Major = -1, Minor = -1; auto First = V.split('.'); auto Second = First.second.split('.'); - if (!First.first.getAsInteger(10, Major) || - !Second.first.getAsInteger(10, Minor)) + if (First.first.getAsInteger(10, Major) || + Second.first.getAsInteger(10, Minor)) return CudaVersion::UNKNOWN; if (Major == 7 && Minor == 0) {
Index: clang/lib/Driver/ToolChains.cpp =================================================================== --- clang/lib/Driver/ToolChains.cpp +++ clang/lib/Driver/ToolChains.cpp @@ -1730,8 +1730,8 @@ int Major = -1, Minor = -1; auto First = V.split('.'); auto Second = First.second.split('.'); - if (!First.first.getAsInteger(10, Major) || - !Second.first.getAsInteger(10, Minor)) + if (First.first.getAsInteger(10, Major) || + Second.first.getAsInteger(10, Minor)) return CudaVersion::UNKNOWN; if (Major == 7 && Minor == 0) {
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits