erichkeane added inline comments.
================ Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16806 + bool InTemplateDefinition = + getLangOpts().CPlusPlus && CurContext->isDependentContext(); + ---------------- cor3ntin wrote: > erichkeane wrote: > > CplusPlus check is now not really beneficial? I'm not sure how much it > > matters now though that these are both just bit-loads. > isDependentContext still does a bunch of work, recursively. I think we should > keep it! Ah, Oh! You're right! It is the Expr class where this is free/just checking a bit. Disregard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144285/new/ https://reviews.llvm.org/D144285 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
