Michael137 added a subscriber: labath.
Michael137 added a comment.

> Hmm, I'd sort of still be inclined to look further at the linkage name option 
> - but maybe the existence of a situation where the usage is built with debug 
> info, but the out of line ctor definitions are all in another library without 
> debug info is a sufficiently motivating use case to justify the addition of 
> these attributes to the ctor declaration. *shrug* Carry on then.

That would've been convenient but I don't think we can get it right with 
attaching the linkage name (even if we are willing to do the search for the 
correct linkage name). That would essentially coalesce the possibly multiple 
definitions of the constructor into a single one (since there's only ever a 
single `CXXConstructorDecl` in the AST for a given constructor in the source)

(CC @labath)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144181/new/

https://reviews.llvm.org/D144181

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to