HazardyKnusperkeks added inline comments.
================
Comment at: clang/lib/Format/TokenAnnotator.cpp:2665
+ if (Style.isVerilog() && Precedence == prec::Comma &&
+ VerilogFirstOfType != nullptr) {
+ addFakeParenthesis(VerilogFirstOfType, prec::Comma);
----------------
owenpan wrote:
> sstwcw wrote:
> > owenpan wrote:
> > > And other places as well.
> > @HazardyKnusperkeks Do you agree? I remember you once said you preferred
> > the `nullptr` style.
> See D144355. Not using `nullptr` in conditionals was one of the first LLVM
> styles I had to get used to when I started contributing.
Apart from Owens comment about the style guide. My personal preference is
without `nullptr`, but I don't know if I maybe said otherwise sometime.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143825/new/
https://reviews.llvm.org/D143825
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
