awarzynski added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:5045 +// Unsupported flang W options +defm : FlangIgnoredDiagOpt<"extra">; ---------------- The name of the sub-project is "Flang", the sub-dir is "flang" and the driver name is "flang-new". What is "flang" referring to in this comment? Also, "-W<arg> options" would be IMHO a bit more descriptive. ================ Comment at: clang/include/clang/Driver/Options.td:5047 +defm : FlangIgnoredDiagOpt<"extra">; +defm : FlangIgnoredDiagOpt<"aliasing">; +defm : FlangIgnoredDiagOpt<"ampersand">; ---------------- How about a test for all the options that follow `-Wextra`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
