eopXD added a comment. Thank you for the patch. May you explain how this would help support multi-versioning?
================ Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:24 + unsigned Minor; + bool operator==(const RISCVExtensionVersion &Vers) const { + return this->Major == Vers.Major && this->Minor == Vers.Minor; ---------------- Does the structure already work as-is? ================ Comment at: llvm/lib/Support/RISCVISAInfo.cpp:190 + RISCVExtensionVersion Version) { + assert(!Exts.count(ExtName.str()) && "Extension already exists"); + Exts[ExtName.str()] = Version; ---------------- Maybe handling this with a compiler error is better than an assertion error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144696/new/ https://reviews.llvm.org/D144696 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits