dang requested changes to this revision. dang added a comment. This revision now requires changes to proceed.
Nice! glad to see this getting fixed. You should add a lit test to ensure we don't regress this behavior in the future. ================ Comment at: clang/include/clang/ExtractAPI/AvailabilityInfo.h:48 private: - using AvailabilityList = llvm::SmallVector<AvailabilityInfo, 4>; + using AvailabilityList = llvm::SmallVector<AvailabilityInfo, 5>; AvailabilityList Availabilities; ---------------- I don't think this change here is necessary. ================ Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:546 + Record, API, [Lang, &ParentContexts](const PathComponent &PC) { + ParentContexts.push_back(serializeParentContext(PC, Lang)); + }); ---------------- Arsenic wrote: > These changes seems to have added by clang-format. > Is there a way to not let clang format edit the code that I haven't touched ? Yes you can use `git-clang-format`, instructions here for setup: https://offlinemark.com/2021/04/02/surgical-formatting-with-git-clang-format/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144940/new/ https://reviews.llvm.org/D144940 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits