rymiel added inline comments.
================
Comment at: clang/unittests/Format/QualifierFixerTest.cpp:733
+ // TODO: Something strange is going on with this formating.
+ verifyFormat("Bar < Foo, const Foo >> ;", "Bar < Foo, Foo const >> ;",
Style);
+
----------------
AlexanderHederstaf wrote:
> rymiel wrote:
> > This... isn't valid syntax? an opening < is missing.
> > Perhaps you could adapt https://github.com/llvm/llvm-project/issues/56111
> > into a test, it seems to be fixed by the patch, but there might still be
> > corner-cases
> Right, I must've focused too much on the missing right >. What is the
> procedure now that the review is accepted. Can I still upload a fix to this
> and to include that issue in the tests?
> What is the procedure now that the review is accepted
No different to the usual! The patch will stay accepted, and reviewers can just
re-approve anyways.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144709/new/
https://reviews.llvm.org/D144709
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
