shafik accepted this revision.
shafik added a comment.
Besides the nitpick, LGTM
================
Comment at: clang/test/CXX/expr/expr.const/p8-2a.cpp:14
-// bad_assert_copyable<N> is not needed for constant evaluation
-// (and thus not instantiated)
+// consteval assert is not instantiated as well.
template<typename T> consteval void assert_copyable() { T t; T t2 = t; }
----------------
How about "Prior to P1937R2 consteval functions were evaluated even in
otherwise unevaluated context, now this is well-formed"
and move it right above the "using check"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145362/new/
https://reviews.llvm.org/D145362
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
