nickdesaulniers planned changes to this revision.
nickdesaulniers added a comment.

In D145416#4172799 <https://reviews.llvm.org/D145416#4172799>, @efriedma wrote:

> I think this is going to change what inputs Sema will accept for "p".  If 
> that's intentional, please add test coverage.  Otherwise, please make a 
> narrower change.

You're hunch is correct, though this change as written doesn't change what Sema 
will accept. Testing this locally, I previously had tried just adding 
`Info.setAllowsMemory();` for `"p"` and NOT `Info.setAllowsRegister();`; that 
caused Sema to reject non-ptr arguments.

I will add test cases regardless.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145416/new/

https://reviews.llvm.org/D145416

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to