tra added a comment. LGTM for NVPTX.
================ Comment at: llvm/lib/Transforms/Instrumentation/SanitizerBinaryMetadata.cpp:134 assert(TargetTriple.isOSBinFormatELF() && "ELF only"); + assert((!TargetTriple.isNVPTX() && !TargetTriple.isAMDGPU()) && + "Device targets are not supported"); ---------------- Nit: `assert(!(TargetTriple.isNVPTX() || TargetTriple.isAMDGPU()))` would be a bit easier to read. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145519/new/ https://reviews.llvm.org/D145519 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits