tra added a comment.

In D145591#4182168 <https://reviews.llvm.org/D145591#4182168>, @yaxunl wrote:

> -x hip and -fopenmp has been a valid combination. -fopenmp with -x hip allows 
> non-offloading OpenMP directives in host code in HIP. It just ignores the 
> offloading directives.

That brings me back to the earlier question -- what do we currently do when 
target directives are encountered when we compile a C++ source w/ OpenMP 
enabled and why HIP shold be handled differently.

If a warning makes sense for target directives with offloading disabled, that 
warning would be equally applicable to C/C++/CUDA & HIP. If that's not the 
case, what am I missing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145591/new/

https://reviews.llvm.org/D145591

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to