owenpan added a comment.

In D145435#4181215 <https://reviews.llvm.org/D145435#4181215>, 
@HazardyKnusperkeks wrote:

> Although I don't think I will use that feature, I still think it might be 
> useful and doesn't really hurt anyone.

It would add extra runtime (especially for large files). We would also run the 
risk of regressions (though unlikely) if for whatever reason an existing 
codebase has files starting with `// clang-format style=`.

I'm still of the opinion that if this is not highly demanded (yet) and can be 
done outside of clang-format, we should not add this feature.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145435/new/

https://reviews.llvm.org/D145435

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to