wanders added a comment. In D144405#4184726 <https://reviews.llvm.org/D144405#4184726>, @erichkeane wrote:
> Looks like this doesn't compile pre-commit, though no idea if that is a > patch-stack issue. Other than test, patch looks fine. Yeah, when uploading the new commit the stack was disorganized. So the build probably started before I got around organizing the stack in correct order. So hopefully clears up when I fix the test (clang-format and const thing) ================ Comment at: clang/test/Frontend/plugin-attribute-pp.cpp:1 +// RUN: split-file %s %t +// RUN: %clang -fplugin=%llvmshlibdir/Attribute%pluginext -E %t/has_attr.cpp | FileCheck %t/has_attr.cpp ---------------- erichkeane wrote: > This split-file thing is weird, don't do that. create 2 tests instead, OR > Just use -x c and -x c++ to change languages (you can use a separate macro to > get __has_c and __has_cpp_attribute right). Right. That should be simpler. Will fix. (it ended up this way because I first added a split to the existing `plugin-attribute.cpp` test with splits) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144405/new/ https://reviews.llvm.org/D144405 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
