peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.
I've set approved from the Arm side. Please leave some time for people in the
US time zone to leave any final comments or ask for extensions. I've left a
suggestion for a comment, but this can be applied prior to commit if you want
to take it up.
================
Comment at: clang/include/clang/Driver/Multilib.h:67
+ /// a subset of the flags derived from the Clang command line options.
+ const flag_set &flags() const { return Flags; }
----------------
Would be good to reference the Multilib Design document's definition and
examples of (what will be renamed in D145567 to tags).
This may require moving the design doc down the stack, probably not necessary
if everything is committed at once.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142905/new/
https://reviews.llvm.org/D142905
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
