aaron.ballman added a comment. It looks like there's still relevant precommit CI failures: `clang-tidy/checkers/readability/identifier-naming-case-violation.cpp` looked related to this patch.
================ Comment at: clang/lib/Lex/PPDirectives.cpp:3189-3192 + if ((MI->isBuiltinMacro() || + SourceMgr.isWrittenInBuiltinFile(MI->getDefinitionLoc())) && + !(getLangOpts().ObjC && isObjCProtectedMacro(II))) + Diag(MacroNameTok, diag::ext_pp_undef_builtin_macro); ---------------- john.brawn wrote: > aaron.ballman wrote: > > Should this diagnostic be suppressed in a system header on the assumption > > that system headers are part of the implementation and thus free to > > undefine/redefine macros at will? > It's already suppressed. ShowInSystemHeader in the Diagnostic tablegen class > determines if a diagnostic is shown when it happens in a system header, and > it's false by default for warnings. Ah, good point! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
