aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D145765#4191800 <https://reviews.llvm.org/D145765#4191800>, @xiongji90 wrote:

> I have simplified the test as you suggested and I also updated release doc to 
> add "__builtin_set_flt_rounds" in fp support section. To 
> `LanguageExtension.rst`, I prefer to creating a patch since we already had 
> another builtin "__builtin_flt_rounds" which was not documented, I plan to 
> document these 2 builtin together.

Documenting the two builtins together in a follow-up patch sounds fine to me, 
thank you!

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145765/new/

https://reviews.llvm.org/D145765

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to