aeubanks added inline comments.

================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1127
+    if (!PassPA.allAnalysesInSetPreserved<AllAnalysesOn<Function>>())
       return;
 
----------------
nikic wrote:
> Hm, aren't we going to skip the CFG check below if only CFGAnalyses are 
> preserved (but not AllAnalyses)?
no longer a worry after D146096


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146003/new/

https://reviews.llvm.org/D146003

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to