sepavloff added inline comments.
================ Comment at: clang/docs/LanguageExtensions.rst:3293 +This builtin is converted to llvm.set.rounding intrinsic in LLVM IR level +and not all targets support this intrinsic, so only x86 and arm targets +support this builtin. Since this builtin changes default floating-point ---------------- If some other target start supporting `llvm.set_rounding` this statement becomes wrong. Maybe just 'some targets'? ================ Comment at: clang/docs/LanguageExtensions.rst:3295 +support this builtin. Since this builtin changes default floating-point +environment, ``#pragma STDC FENV_ACCESS ON`` is required. + ---------------- Not necessary. Options `-ffp-model=strict` or `-frounding-math` also can be used. I would remove this statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146188/new/ https://reviews.llvm.org/D146188 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
