mamrami added inline comments.
================ Comment at: flang/test/Driver/code-gen-rv64.f90:1 +! Test -emit-obj (RISC-V 64) + ---------------- sunshaoce wrote: > mamrami wrote: > > sunshaoce wrote: > > > awarzynski wrote: > > > > mamrami wrote: > > > > > Hi :) > > > > > It seems like the test fails: > > > > > https://buildkite.com/llvm-project/premerge-checks/builds/141302#0186e55e-199e-401d-ab9f-9f3d47ec87af > > > > > I see it in my non related patch https://reviews.llvm.org/D146132 > > > > Sorry about that :( > > > > > > > > ``` > > > > line 3: llvm-readelf: command not found > > > > ``` > > > > > > > > There are 3 options: > > > > * revert > > > > * add `llvm-readelf` here > > > > https://github.com/llvm/llvm-project/blob/main/flang/test/CMakeLists.txt#L61 > > > > * updated the test to use `llvm-objdump` instead > > > > > > > > HTH. > > > Thanks! I've submitted in https://reviews.llvm.org/D146204. > > Hi again! > > The test passed after the fix but it fails again: > > https://buildkite.com/llvm-project/premerge-checks/builds/141905#0186fa14-2339-4c0c-9966-dea23592a86b > > > I noticed this error before, but @DavidSpickett haven't fixed yet. I'll fix > it now. > https://reviews.llvm.org/rG9f93b71f20ea thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
