awarzynski added inline comments.
================ Comment at: flang/test/Driver/mlir-pass-pipeline.f90:15-18 +! O2-NEXT: Canonicalizer +! ALL-NEXT: LowerHLFIRIntrinsics +! ALL-NEXT: BufferizeHLFIR +! ALL-NEXT: ConvertHLFIRtoFIR ---------------- tblah wrote: > awarzynski wrote: > > It looks like these passes are run unconditionally - what's the > > `-flang-experimental-hlfir` flag for then? > Yes. @vzakhari requested the passes should run unconditionally. > > `-flang-experimental-hlfir` controls whether the HLFIR lowering is used. Ok, so so far you have updated the default pass pipelines and that's what you are testing here. However, this patch is about `-flang-experimental-hlfir` - can you add a test for this flag? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146278/new/ https://reviews.llvm.org/D146278 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
