shafik added a comment.

As I noted in the bug report not doing `D.setInvalidType();` does fix this bug 
and seems harmless since the error diagnostic should prevent us from getting to 
codegen but it is not clear to me if this has other negative impacts. Reading 
your replies it is not obvious you looked at this path or not.

I would not mind a quick fix but I think we should have a plan for a more 
correct fix before we do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146426/new/

https://reviews.llvm.org/D146426

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to