aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM with a nit and a question, but can you add a release note when you land to let users know about the changes? ================ Comment at: clang/tools/libclang/CIndex.cpp:4017-4019 + if (!CIdx) + return CXError_InvalidArguments; + SmallString<64> ClangPath( ---------------- Just for visual separation. ================ Comment at: clang/tools/libclang/CIndex.cpp:4022 + llvm::sys::path::append(ClangPath, "bin"); + llvm::sys::path::append(ClangPath, "clang"); + ---------------- I suspect this doesn't matter *too* much, but... on Windows, wouldn't this be `clang.exe` instead? (This isn't new to your patch, so mostly wondering if there's a separate issue we should track.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146497/new/ https://reviews.llvm.org/D146497 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
