Re: [PATCH] D23530: Remove excessive padding from BarrierOp, PrefetchOp, PSBHintOp.

[Alexander Shaposhnikov via cfe-commits]

alexshap updated this revision to Diff 68128.
alexshap added a comment.

Address code review comment


https://reviews.llvm.org/D23530

Files:
  lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp

Index: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
===================================================================
--- lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
+++ lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
@@ -208,9 +208,9 @@
   };
 
   struct BarrierOp {
+    const char *Data; 
+    unsigned Length;
     unsigned Val; // Not the enum since not all values have names.
-    const char *Data;
-    unsigned Length;
   };
 
   struct SysRegOp {
@@ -226,15 +226,15 @@
   };
 
   struct PrefetchOp {
-    unsigned Val;
     const char *Data;
     unsigned Length;
+    unsigned Val;
   };
 
   struct PSBHintOp {
-    unsigned Val;
     const char *Data;
     unsigned Length;
+    unsigned Val;
   };
 
   struct ShiftExtendOp {



Index: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
===================================================================
--- lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
+++ lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
@@ -208,9 +208,9 @@
   };
 
   struct BarrierOp {
+    const char *Data; 
+    unsigned Length;
     unsigned Val; // Not the enum since not all values have names.
-    const char *Data;
-    unsigned Length;
   };
 
   struct SysRegOp {
@@ -226,15 +226,15 @@
   };
 
   struct PrefetchOp {
-    unsigned Val;
     const char *Data;
     unsigned Length;
+    unsigned Val;
   };
 
   struct PSBHintOp {
-    unsigned Val;
     const char *Data;
     unsigned Length;
+    unsigned Val;
   };
 
   struct ShiftExtendOp {

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits