SBallantyne added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:111 +llvm::codegenoptions::DebugInfoKind +DebugLevelToInfoKind(const llvm::opt::Arg &A); + ---------------- awarzynski wrote: > SBallantyne wrote: > > awarzynski wrote: > > > awarzynski wrote: > > > > CamelCase or camelCase? ;-) > > > Sorry, I meant that this function uses wrong casing. It ought to be > > > `debugLevelToInfoKind` and `addDebugInfoKind`: > > > https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly > > I thought that the general rule was that the style guide should be followed > > apart from when there is already code in a particular style in a file, > > however i have realised that while most functions in this file are > > `CamelCase`, there are some that are `camelCase`, so i am unsure of what is > > the right way. > Yes, it's very confusing :( > > You are right about the official guidelines (at least that's how I understand > them). In this case the style used in this file is inconsistent so you can't > follow that (i.e. because there are multiple styles used here). In situations > like this I would follow the official style guideline instead. Sounds reasonable, I've changed it to follow style guideline instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146814/new/ https://reviews.llvm.org/D146814 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
