denizevrenci added inline comments.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:75-79
+ // CHECK-MESSAGES-NOT: :[[@LINE-1]]:11: warning: an exception may be thrown
in function 'b_ShouldNotDiag' which should not throw exceptions
+ if (b == 0)
+ throw b;
+
+ co_return a / b;
----------------
ChuanqiXu wrote:
> I don't understand why we shouldn't emit the warning here. Since the function
> is marked `noexcept` but it may throw actually in `unhandled_exception`. I
> think it is meaningful to warn for this.
Right, I now see that this behavior is different between Clang's `-Wexceptions`
and Clang Tidy's `bugprone-exception-escape`. The former does not warn on this
code, the latter does.
```
int foo() {
throw 1;
}
int bar() noexcept {
return foo();
}
```
We need to treat coroutines differently and check whether `task::task`,
`promise::promise`, `promise::initial_suspend`, `promise::get_return_object`,
and `promise::unhandled_exception` can throw instead of the body of the
coroutine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
