hokein added a comment. Sorry for the delay. I totally missed it.
================ Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22 @@ +21,2 @@ + DESTINATION share/clang + COMPONENT find-all-symbols) ---------------- Eugene.Zelenko wrote: > hokein wrote: > > I think we can put it in `clang-include-fixer` as find-all-symbols is a > > sub-tool of include-fixer. > In other make files executable name and COMPONENT for scripts are same. > Should I add COMPONENT to find-all-symbols executable too? My previous comment is just my personal preference, not a strong opinion. The patch is good enough now, feel free to submit it. Keeping the `find-all-symbols` executable binary in `RUNTIME DESTINATION bin` is fine. Repository: rL LLVM https://reviews.llvm.org/D23045 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits