agozillon added a comment. In D147324#4245932 <https://reviews.llvm.org/D147324#4245932>, @kiranchandramohan wrote:
> LG. This portion of the patch was accepted in > https://reviews.llvm.org/D145264. > > See inline comment about location of LLVM Dialect tests. You may either > remove the LLVM dialect tests from this patch and land it. Or you can submit > this and move the tests in a separate NFC patch and submit without review. Hi Kiran, Thanks for the quick reply. I'll do the former and remove the tests and land the patch today (back tracking on the previous statement of leaving landing it till later), I don't believe they add anything to the test suite as there is no modifications between FIR -> LLVM Dialect as far as this attribute and the ModuleOp go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147324/new/ https://reviews.llvm.org/D147324 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
