doru1004 added inline comments.

================
Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33
+//.
+// CHECK-NVIDIA: @local_a = internal addrspace(3) global [10 x i32] 
zeroinitializer, align 4
+//.
----------------
jhuber6 wrote:
> Shouldn't the Nvidia version also be undefined? Not sure why this should vary 
> depending on the target.
Perhaps NVIDIA code path can tolerate a zeroinitializer? I don't want to change 
it if it's not needed. I am basing this check on the code path for AMD GPUs and 
the initial bug that was reported.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147572/new/

https://reviews.llvm.org/D147572

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to