This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb206cde3504c: [Clang][Attributes] Add MeaningfulToClassTemplateDefinition to unavailable… (authored by shafik). Herald added a project: clang.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147495/new/ https://reviews.llvm.org/D147495 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Attr.td clang/test/SemaCXX/attr-unavailable.cpp Index: clang/test/SemaCXX/attr-unavailable.cpp =================================================================== --- clang/test/SemaCXX/attr-unavailable.cpp +++ clang/test/SemaCXX/attr-unavailable.cpp @@ -172,3 +172,13 @@ template <class T> int phase_one_unavailable2(int x = unavailable_int()) __attribute__((unavailable)) {} + +namespace GH61815 { +template <class _ValueType = int> +class __attribute__((unavailable)) polymorphic_allocator {}; // expected-note 2 {{'polymorphic_allocator<void>' has been explicitly marked unavailable here}} + +void f() { + polymorphic_allocator<void> a; // expected-error {{'polymorphic_allocator<void>' is unavailable}} + polymorphic_allocator<void> b; // expected-error {{'polymorphic_allocator<void>' is unavailable}} +} +} Index: clang/include/clang/Basic/Attr.td =================================================================== --- clang/include/clang/Basic/Attr.td +++ clang/include/clang/Basic/Attr.td @@ -2848,6 +2848,7 @@ "IR_ARCInitReturnsUnrelated", "IR_ARCFieldWithOwnership"], 1, /*fake*/ 1>]; let Documentation = [Undocumented]; + let MeaningfulToClassTemplateDefinition = 1; } def DiagnoseIf : InheritableAttr { Index: clang/docs/ReleaseNotes.rst =================================================================== --- clang/docs/ReleaseNotes.rst +++ clang/docs/ReleaseNotes.rst @@ -210,6 +210,9 @@ - Clang now checks for completeness of the second and third arguments in the conditional operator. (`#59718 <https://github.com/llvm/llvm-project/issues/59718>`_) +- There were some cases in which the diagnostic for the unavailable attribute + might not be issued, this fixes those cases. + (`61815 <https://github.com/llvm/llvm-project/issues/61815>`_) Bug Fixes in This Version -------------------------
Index: clang/test/SemaCXX/attr-unavailable.cpp =================================================================== --- clang/test/SemaCXX/attr-unavailable.cpp +++ clang/test/SemaCXX/attr-unavailable.cpp @@ -172,3 +172,13 @@ template <class T> int phase_one_unavailable2(int x = unavailable_int()) __attribute__((unavailable)) {} + +namespace GH61815 { +template <class _ValueType = int> +class __attribute__((unavailable)) polymorphic_allocator {}; // expected-note 2 {{'polymorphic_allocator<void>' has been explicitly marked unavailable here}} + +void f() { + polymorphic_allocator<void> a; // expected-error {{'polymorphic_allocator<void>' is unavailable}} + polymorphic_allocator<void> b; // expected-error {{'polymorphic_allocator<void>' is unavailable}} +} +} Index: clang/include/clang/Basic/Attr.td =================================================================== --- clang/include/clang/Basic/Attr.td +++ clang/include/clang/Basic/Attr.td @@ -2848,6 +2848,7 @@ "IR_ARCInitReturnsUnrelated", "IR_ARCFieldWithOwnership"], 1, /*fake*/ 1>]; let Documentation = [Undocumented]; + let MeaningfulToClassTemplateDefinition = 1; } def DiagnoseIf : InheritableAttr { Index: clang/docs/ReleaseNotes.rst =================================================================== --- clang/docs/ReleaseNotes.rst +++ clang/docs/ReleaseNotes.rst @@ -210,6 +210,9 @@ - Clang now checks for completeness of the second and third arguments in the conditional operator. (`#59718 <https://github.com/llvm/llvm-project/issues/59718>`_) +- There were some cases in which the diagnostic for the unavailable attribute + might not be issued, this fixes those cases. + (`61815 <https://github.com/llvm/llvm-project/issues/61815>`_) Bug Fixes in This Version -------------------------
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits