shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land.
Thank you for taking care of this, LGTM ================ Comment at: clang/lib/Sema/SemaInit.cpp:2646 + if (Loc.isInvalid()) + // This could happen with a "null" designator (i.e. an anonymous + // union/struct). Do our best to approximate the location. ---------------- nitpick, I think the comment should be above the `if` statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147673/new/ https://reviews.llvm.org/D147673 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits