Endill added a comment. In D147839#4258681 <https://reviews.llvm.org/D147839#4258681>, @shafik wrote:
> In D147839#4257394 <https://reviews.llvm.org/D147839#4257394>, @Endill wrote: > >> Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary >> template instantiation (presumably to find overloaded unary `&`), and make >> Clang compliant since 3.4 > > Nice approach! Credits go to Aaron, actually. We discussed this DR during his office hours yesterday. In D147839#4258682 <https://reviews.llvm.org/D147839#4258682>, @shafik wrote: > LGTM, thank you again for all the effort in documenting these and adding > tests, it is much appreciated. Thank you for giving them thorough review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147839/new/ https://reviews.llvm.org/D147839 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits