aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
The changes seem reasonable to me. ================ Comment at: clang/include/clang/AST/RawCommentList.h:122 + StringRef Text = getRawText(SourceMgr); + if (Text.size() < 6 || Text[0] != '/') + return false; ---------------- cor3ntin wrote: > aaron.ballman wrote: > > Just to double-check, we don't have to worry about there being leading > > whitespace in `Text` do we? > Afaict, we always have a valid comment, starting with / (and ending with / > for a multi line comment). We might not have a comment valid for > documentation purposes. Excellent -- I was poking around and it seemed like we do trim the text before forming the comment object, so yay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148029/new/ https://reviews.llvm.org/D148029 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits