Eugene.Zelenko marked an inline comment as done. ================ Comment at: include/clang/Basic/IdentifierTable.h:103 @@ -95,1 +102,3 @@ + return getLength() == StrLen-1 && + memcmp(getNameStart(), Str, StrLen-1) == 0; } ---------------- memcpy result is three state, so applying Boolean operator is not correct.
================ Comment at: include/clang/Lex/PreprocessorOptions.h:22 @@ -23,2 +21,3 @@ namespace llvm { + class MemoryBuffer; ---------------- I wanted to make spacing consistent. Same in other places. Actually, Include What You Use recommended to include MemoryBuffer.h. MemoryBuffer is used in smart pointers, but I remember that I encountered problems in LLDB MSVC builds, where forward declaration was not enough for such usage. Repository: rL LLVM https://reviews.llvm.org/D23595 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits