craig.topper added inline comments.
================ Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template<typename T> struct S { T var; }; + ---------------- @erichkeane does this cover the dependent case or were you looking for something else? Here are on the only mentions of template I see in SVE tests that use this attribute. ``` clang/test$ ack template `ack arm_sve_vector -l` CodeGenCXX/aarch64-mangle-sve-fixed-vectors.cpp 37:template <typename T> struct S {}; SemaCXX/attr-arm-sve-vector-bits.cpp 16:template<typename T> struct S { T var; }; ``` Here is the result for this patch ``` clang/test$ ack template `ack riscv_rvv_vector -l` CodeGenCXX/riscv-mangle-rvv-fixed-vectors.cpp 48:template <typename T> struct S {}; SemaCXX/attr-riscv-rvv-vector-bits.cpp 12:template<typename T> struct S { T var; }; ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145088/new/ https://reviews.llvm.org/D145088 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits