erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land.
This LGTM, though curious about the re-ordering. ================ Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:135 AttributeCommonInfo(const IdentifierInfo *AttrName, const IdentifierInfo *ScopeName, SourceRange AttrRange, ---------------- Did these two ctors swap places somehow? There's something goofy going on here? Or is this just to make the delegation of ctors more sensible? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148148/new/ https://reviews.llvm.org/D148148 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits