kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/SystemIncludeExtractor.cpp:340
+ // is not installed.
+ if (Lang == "objective-c++-header") {
+ Lang = "c++-header";
----------------
this feels like too much of a layering violation and might (will?) go wrong in
cases where language was explicitly set to `objective-c++-header`.
if the user is relying on fallback commands with an overwrite of `Compiler:` in
the config && --query-driver globs, would it be too much of a hassle to expect
them to have a `CompileFlags: Add: ...` block too?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147905/new/
https://reviews.llvm.org/D147905
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
