jrtc27 added inline comments.
================ Comment at: clang/lib/Sema/SemaDecl.cpp:5041 case DeclSpec::TST_enum: return 4; default: ---------------- Why not just always pass the full DeclSpec and handle the class case here, maybe with a bool to allow other users to not need to treat enum class as different? ================ Comment at: clang/lib/Sema/SemaDecl.cpp:5052-5053 + } + } + else{ + return GetDiagnosticTypeSpecifierID(DS.getTypeSpecType()); ---------------- Read the style guide ================ Comment at: clang/lib/Sema/SemaDecl.cpp:5318 + << AL << GetDiagnosticTypeSpecifierID(DS); + } } ---------------- ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits