shafik added inline comments.
================
Comment at: clang/test/CXX/class/class.compare/class.compare.default/p4.cpp:162
+
+my_struct<non_constexpr_type> obj; // extension-note {{in instantiation of
template class 'GH61238::my_struct<GH61238::non_constexpr_type>' requested
here}}
+}
----------------
aaron.ballman wrote:
> Can you add an instantiation that does use a constexpr suitable type to show
> that we don't issue the diagnostic on that instantiation, or do you think
> that is sufficiently covered by other test coverage?
I think I need to add more tests, or add comments to existing tests wrt to
`p2448`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146090/new/
https://reviews.llvm.org/D146090
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
